Download Faculty Leaves Planning Report tabs as spreadsheet #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going to transform the table into json to get the format we want, rather than munging the table DOM. We'll use `usePersonTableData` composable to do the work. But, I want to test it to make sure it's not messing things up. If this works, we could probably eliminate a bunch of logic within the PersonTable components and just use the records from `usePersonTableData`
fixes extrra people showing up on the "TA" tab
in filename, scrub groupname of special chars
termId is not a value on leave... it's an array, so groupBy won't work
initial render is much slower when these are computed. It's better to compute the spreadsheet rows when needed. Also, show loading icon while spreadsheet is building
cmcfadden
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to download the Instructors, TAs, and Courses data from the Faculty Leaves Planning Report page.
lookupsandfilters.Web Workers
Spreadsheet creation can take awhile on larger groups (ANTH, HIST). It blocks the main thread, making the browser unresponsive, and sometimes prompting the user to kill the page.
To resolve this, I moved spreadsheet work into Web Workers.
There's a known issue using web workers using vite, laravel, and typescript. As a workaround, I created a
ViteWorkerwrapper forWorker.Web workers resolved the browser lock-up issue, but the creation of some spreadsheets still takes long enough that you begin to wonder if the spinner will actually stop. To improve this, the user is shown progress. (The progress is faked a little, since we can't only tell when sheet calculation is complete).
On dev for testing: https://cla-groups-dev.oit.umn.edu/course-planning/groups/6